Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with contao/imagine-svg 1.0 #71

Merged
merged 7 commits into from
Jun 13, 2020

Conversation

ausi
Copy link
Member

@ausi ausi commented May 21, 2020

Depends on the release of contao/imagine-svg 1.0.0

@ausi ausi self-assigned this May 21, 2020
composer.json Outdated Show resolved Hide resolved
@ausi ausi force-pushed the fix/imagine-svg-compatibility branch from 0b70b63 to 55267d3 Compare May 26, 2020 14:00
@ausi ausi force-pushed the fix/imagine-svg-compatibility branch from 55267d3 to 71e3c49 Compare May 26, 2020 14:15
Copy link
Member

@aschempp aschempp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How come the package is not actually required?

@ausi
Copy link
Member Author

ausi commented May 27, 2020

How come the package is not actually required?

It is an optional dependency. If you do not need SVG support, contao/image works just fine without contao/imagine-svg.

composer.json Outdated Show resolved Hide resolved
@ausi ausi changed the title Add compatibility with imagine-svg 1.0 Compatibility with contao/imagine-svg 1.0 Jun 13, 2020
@ausi ausi merged commit f2be7e4 into contao:master Jun 13, 2020
@ausi ausi deleted the fix/imagine-svg-compatibility branch June 13, 2020 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants