Remove superfluous words from the English allow list

[fritzmg]

This cleans up the English allow list a bit.

[Total-Reality]

1. Couldn't the following words also be removed in this context?:

• Assistant
• Avatar
• base
• Card
• Container
• etc
• login
• Notification
• notification
• Panel
• scalable
• Social
• Spam
• staging
• Ticker

2. The following words are misspelled and could be removed also (but it is possible that this words are part of the name of extensions):

• Api (already exists in default.txt as API)
• infos (info is correct)
• navigations (navigation is correct)
• Socialmedia (Social media is correct)
• youtube (already exists in default.txt as YouTube)

3. The following words should be moved to default.txt (most of them exist in de.yml + en.yml btw.)

• AntiSpam
• Bootstrapper
• Cookiebar
• EasyThemes
• Filemanager
• Geocode
• Geodata
• Jobposting
• LinkedIn
• Mega
• Merger
• Picker
• Plenta
• Slider
• Social
• Softleister
• Teaserbox
• tmp

[fritzmg]

@Total-Reality feel free to create a separate PR for that.

[Total-Reality]

@Total-Reality feel free to create a separate PR for that.

Okay, thank you. I will create one as soon as the lint action (bug?) is fixed #414

[xchs]

What's the problem with the linter?

[fritzmg]

Unknown, see #414

[Total-Reality]

Is it possible that this problem occurs because you removed words that are not in the dictionary but used by at least one extension?

[fritzmg]

That would be identified by the action itself. But the action is not running for some reason.

[aschempp]

@fritzmg are you going to finish this PR? 😊

[fritzmg]

It was already finished, I just could not figure out what the problem with the linter was. I will update the PR again.

[fritzmg]

@aschempp since the linter does not run automatically I unfortunately have currently no way to test the changes. Someone would need to test it in their local environment.

[aschempp]

Someone would need to test it in their local environment.

Could that someone be you? 🙃
What would happen if a word is missing in the dictionary? Would the next PR fail or would indexing fail forever?

[fritzmg]

Could that someone be you? 🙃

I could, but I would need to update my WSL setup. Someone already on a Unix system might have an easier time though.

What would happen if a word is missing in the dictionary? Would the next PR fail or would indexing fail forever?

I don't know, didn't you build the Indexing? ;)
My assumption is that the linter is only used for PRs.

[aschempp]

@fritzmg I would suggest to merge this as-is and check if it works. There's apparently a cronjob to check the files every month (https://github.com/contao/package-metadata/actions/runs/3219322454/jobs/5264551105) but not sure if that is taken care of anyway 🙈

[fritzmg]

Yes, I think this can be merged as is. If a word is missing, it will show up in subsequent meta data PRs anyway.