Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show task progress while it is active #100

Closed
wants to merge 1 commit into from

Conversation

axe312ger
Copy link
Contributor

@axe312ger axe312ger commented Apr 7, 2017

This pull request is based on #98. It should be merged first!

Display current task progress with percentage and estimated time to finish below the task. Verbose logging to CI should work pretty well.

The output of the progress observable might need a progress bar or other improvements.

Error display is not yet implemented and might cause visual issues with the update renderer, this needs some more work :)

Also, i am pretty sure the observable code can be optimised.

Standard progress display

asciicast

Verbose progress display for CI

asciicast

@axe312ger axe312ger self-assigned this Apr 7, 2017
@axe312ger axe312ger changed the title show progress Show task progress while it is active Apr 7, 2017
@Khaledgarbaya
Copy link
Contributor

@axe312ger what's up with this PR ?

@axe312ger
Copy link
Contributor Author

We should discuss this, since the error output with the current error handling is broken.

Also, since getFullSourceSpace is kinda the only function used by contentful-export, we may move it to the contentful-export repo to ease up maintenance. Why? Because we are changing the API here, it is then Observable based and no more Promise based which will break custom implementations of contentful-batch-libs

--> https://github.com/contentful/contentful-export/search?utf8=%E2%9C%93&q=contentful-batch-libs&type=

Copy link
Contributor

@Khaledgarbaya Khaledgarbaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one small comments, maybe @zcei can give more feedback on the Observable

@@ -8,7 +8,9 @@
}]
],
"plugins": [
"add-module-exports"
"add-module-exports",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you also remove the "debug": true, it's so annoying when building

@axe312ger
Copy link
Contributor Author

This is now fully implemented via listr itself, promises and awesome loops. All without RxJS. Closing this one and deleting the branch...

@axe312ger axe312ger closed this Oct 25, 2017
@axe312ger axe312ger deleted the feat/task-listing-observables branch October 25, 2017 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants