Fix/sort entries #125
Merged
Fix/sort entries #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reorders them so that entries which are linked from other entries always come first in the order. This ensures that when we publish entries, we are not publishing entries which contain links to other entries which haven't been published yet.
|
How does this work with cyclic dependencies? Also two side notes:
|
axe312ger
approved these changes
Jun 26, 2017
There was a problem hiding this comment.
Found some issues, fixed it. @Khaledgarbaya it is your turn for review.
axe312ger
force-pushed
the
fix/sort-entries
branch
from
31b8101
to
6f01d17
Compare
it doesn't 😅 but this is not fixable via sorting, we need another solution for circular references.
good point
correct, never. So I fixed it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reorders them so that entries which are linked from other entries always
come first in the order. This ensures that when we publish entries, we
are not publishing entries which contain links to other entries which haven't been published yet.
With this, we can remove the workaround loop in
contentful-import