Add execption handler for guzzle_json_decode #40
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If request fails -
\Contentful\Core\Api\Requester::createCustomException
is called, which assumes that response body will always be valid JSON string - but unfortunately in rare cases it isn't. Invalid response body passed toguzzle_json_decode
results inInvalidArgumentException
witch MUST be caught otherwise it propagates up the frame and source of original exception no longer can be determined.This Pull Request adds additional exception handling for cases when
guzzle_json_decode
fails and adds additional exception class for such cases.