Added php8 support (release 3.1.0) #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds PHP8 support to the contentful core. It does the following: - Bump the version to 3.1.0 (new minor) - Add a php8 image to the CI to run the tests on php8 - Allow PHP8 in composer.json The code was verified against the official breaking changes guide [0]. Note that code coverage is not yet supported by phpunit on php8. As it should be pretty much the same as on older PHP versions, however, this is accepted for now. [0] https://www.php.net/manual/en/migration80.php
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds PHP8 support to the contentful core. It does the
following:
The code was verified against the official breaking changes guide [0].
Note that code coverage is not yet supported by phpunit on php8. As it
should be pretty much the same as on older PHP versions, however, this
is accepted for now.
[0] https://www.php.net/manual/en/migration80.php
This replaces #46 (not possible to change the target branch and this enables a
-dev-release first) and #44 (no CI integration). Will be merged once the code is tested with other repos.