Fix error where usageParams were being set incorrectly #34
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Observed:
When running contentful-export against a space with a larger than max size, the 400 error "Response size too big, was: x. Maximum allowed response size: 7340032b." is thrown. This happens even when maxAllowedLimit is set in options.
Reason:
This happens because runContentfulExport does not handle usageParams correctly. Inside of the runContentfulExport function,
let {opts, errorLogFile} = usageParams
is set. ES6 interprets this to meanopts = usageParams.ops
and usageParams does not have the property opts on it. usageParams comes in exactly as it is entered into options.Fix:
let opts = usageParams
should be set first. This will fix the issue setting maxAllowedLimit and includeDrafts. However, errorLogFile is still undefined.Next Steps:
errorLogFile is not used when calling runContentfulExport within contentful-export/bin/contentful-export.