WIP - Refactor: replace test suite with vitest #2328
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
Bumps [@types/lodash](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/lodash) from 4.17.4 to 4.17.5. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/lodash) --- updated-dependencies: - dependency-name: "@types/lodash" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
axe312ger
changed the base branch from
refactor/modern-esm-support
to
build/cleanup-dependencies
* build: upgrade typescript to v5 * style: update eslint to support latest typescript and apply it (#2338)
axe312ger
force-pushed
the
refactor/modern-testing
branch
from
c9c970b
to
6086602
Compare
Base automatically changed from
build/cleanup-dependencies
to
test/fix-integration
July 17, 2024 14:15
This was referenced Jul 24, 2024
axe312ger
commented
Jul 24, 2024
| @@ -25,7 +25,8 @@ describe('Entity Locale', () => { | |||
| }) | |||
| }) | |||
|
|
|||
| test('Locale collection is wrapped', async () => { | |||
| // @todo why is this failing? | |||
| test.skip('Locale collection is wrapped', async () => { | |||
There was a problem hiding this comment.
@todo this test is failing, but should not do so!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As this is the only public repo with mocha/chai/sinon left, this moves it to the modern jest/vitest syntax.
We did the same for the sdk-core and the contentful.js --> contentful/contentful-sdk-core#438 + contentful/contentful.js#2169
Very much WIP - still trying to get myself deeper into the syntax of the SDK and test suite s😅