Mitigate for people using contentful.rb to create references #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| when Hash then | ||
| attr | ||
| end | ||
| if attr.is_a? Entry |
There was a problem hiding this comment.
This could be changed to attr.is_a? Entry || attr.is_a? ::Contentful::Entry, same goes for asset
There was a problem hiding this comment.
I think that a proper solution though, is to use the to_management_entry method in contentful_model, but this would anyway make it "easier" to work with cross-sdk content outside of rails, so I consider this approach here valid
|
Could you add specs for this use case? |
|
Thanks @toadle for you help! Cheers |
|
@dlitvakb Here you go. A bit hacky with the |
|
Thanks @toadle! Merging Cheers |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix contentful/contentful_model#36
I know it is a bit hacky, but the
class.ancestors-thing was the only way to keep thecontentful.rb-dependency out of there.