Fix EnvironmentAware#environment_id when building entries or assets #195
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently both
content_type.entries.new
andenvironment.assets.new
(basicallyContentTypeEntryMethodsFactory#new
andEnvironmentEntryMethodsFactory#new
) don't work corrently when enviorment is notmaster
. An object that is returned is always targeted tomaster
content_type.entries.new
caseIn this case,
enviorment_id
doesn't calculate properly, becausesys
doesn't really have any information about the current environment. But there iscontent_type
reader that has#enviorment_id
.environment.assets.new
caseIn this case,
sys[:enviorment]
is present, but it is notContentful::Management::Link
, it isContentful::Management::Environment
.This PR extends
EnvironmentAware#environment_id
and adds support for both cases. It might even fix other similar casesIt would be great to cover that with integrations specs. Unfortunately, I don't have access to the testing Contentful account, so I can just draft the specs but they need to be finalised by someone with the access