Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retrieves one user by ID from the space & organization #217

Merged
merged 9 commits into from
Nov 9, 2020
Merged

Retrieves one user by ID from the space & organization #217

merged 9 commits into from
Nov 9, 2020

Conversation

rubydog
Copy link
Collaborator

@rubydog rubydog commented Oct 21, 2020 •
edited

@rubydog rubydog requested a review from dlitvakb October 21, 2020 09:39
dlitvakb
dlitvakb approved these changes Oct 21, 2020
View reviewed changes
Copy link
Contributor

@dlitvakb dlitvakb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rubydog rubydog changed the title Retrieves one user by ID from the space Retrieves one user by ID from the space & organization Oct 30, 2020
@dlitvakb
Copy link
Contributor

dlitvakb commented Nov 4, 2020

@rubydog could you refactor the OrganizationUser to reuse the User logic as the users by space do?

Cheers

@dlitvakb dlitvakb merged commit baee58e into contentful:master Nov 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlitvakb dlitvakb dlitvakb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rubydog @dlitvakb