Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reinstate support for simple assignments to fields #62

Merged
merged 2 commits into from
Jun 4, 2015
Merged

Reinstate support for simple assignments to fields #62

merged 2 commits into from
Jun 4, 2015

Conversation

neonichu
Copy link
Contributor

@neonichu neonichu commented Jun 3, 2015

Fixes #61

neonichu added a commit that referenced this pull request Jun 3, 2015
@neonichu
Added Changelog entry for #62
79b565d
@neonichu
Copy link
Contributor Author

neonichu commented Jun 3, 2015

I broke this in 133f58c, the fields accessor now returns a copy of entry values, that's why using it to assign values didn't work anymore. While fixing it, I also added an apparently missing spec for the _with_locales assignments.

@neonichu neonichu assigned neonichu and pxlpnk and unassigned neonichu Jun 3, 2015
pxlpnk added a commit that referenced this pull request Jun 4, 2015
@pxlpnk
Merge pull request #62 from contentful/fix-simple-assignments
54ffbeb 
Reinstate support for simple assignments to fields
@pxlpnk pxlpnk merged commit 54ffbeb into master Jun 4, 2015
@pxlpnk pxlpnk deleted the fix-simple-assignments branch June 4, 2015 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@pxlpnk pxlpnk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@neonichu @pxlpnk