Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies and fix typescript errors #211

Merged
merged 6 commits into from Jul 30, 2019
Merged

Conversation

Khaledgarbaya
Copy link
Contributor

Summary

Description

Motivation and Context

Todos

  • Implemented feature
  • Feature with pending implementation

Screenshots (if appropriate):

@Khaledgarbaya Khaledgarbaya changed the title Update dependencies and fix typescript errors WIP: Update dependencies and fix typescript errors Jul 25, 2019
@Khaledgarbaya Khaledgarbaya changed the title WIP: Update dependencies and fix typescript errors Update dependencies and fix typescript errors Jul 29, 2019
@Khaledgarbaya
Copy link
Contributor Author

I keep hitting the rate limit for environment creation on the CI let's wait till tomorrow

@codecov
Copy link

codecov bot commented Jul 30, 2019

Codecov Report

Merging #211 into master will decrease coverage by 2.6%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #211      +/-   ##
==========================================
- Coverage   88.12%   85.52%   -2.61%     
==========================================
  Files          97       97              
  Lines        2485     2576      +91     
  Branches      278      298      +20     
==========================================
+ Hits         2190     2203      +13     
- Misses        238      281      +43     
- Partials       57       92      +35
Impacted Files Coverage Δ
src/lib/intent/composed-intent.ts 63.33% <ø> (-0.41%) ⬇️
src/lib/intent-validator/content-transform.ts 100% <ø> (ø) ⬆️
...rc/lib/migration-chunks/validation/content-type.ts 95.72% <ø> (ø) ⬆️
src/lib/action/entry-derive.ts 94.44% <100%> (ø) ⬆️
src/lib/intent-validator/field-movement.ts 64.1% <100%> (-35.9%) ⬇️
src/lib/migration-steps/dispatch-proxy.ts 83.33% <100%> (ø) ⬆️
src/bin/cli.ts 75.51% <100%> (ø) ⬆️
src/lib/fetcher.ts 95.58% <100%> (ø) ⬆️
src/bin/lib/contentful-client/proxy.ts 82.35% <100%> (+82.35%) ⬆️
src/lib/migration-steps/index.ts 96.69% <100%> (ø) ⬆️
... and 34 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df609a9...5ba28dd. Read the comment docs.

Copy link
Contributor

@phoebeschmidt phoebeschmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just some tiny debugger statements, otherwise 👍

src/lib/offline-api/validator/schema/fields-schema.ts Outdated Show resolved Hide resolved
test/unit/lib/intent-validator/content-transform.spec.ts Outdated Show resolved Hide resolved
@Khaledgarbaya Khaledgarbaya merged commit bf9bcf7 into master Jul 30, 2019
@Khaledgarbaya Khaledgarbaya deleted the update-cma branch July 30, 2019 13:01
@phoebeschmidt
Copy link
Contributor

🎉 This PR is included in version 0.19.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants