Speed up localization synching #107
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @sjaindl! Thanks for catching that and creating this PR. I'll create separate PR that will consist of your addition and with one more change for creating/updating assets. I noticed there might be issue when you have localized assets and then you may end up with the same invalid behaviour like we had in 0.17.1. Many thanks! |
Merged
|
@sjaindl 0.17.3 is released now. Many thanks for your input! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We noticed the same crashes when updating entries that have been fixed in the latest 0.17.2 release (bb43c16).
I have compared our 2 fixes and found out that our solution has a better performance when there are multiple locales. Did a few time measurements on the different environments we have. They each have 2-4 localizations.
I can attach some measured times if you are interested.
This commit optimizes the locales loop from O(L^2) to O(L) runtime by using a dictionary lookup instead of a linear array search. This especially increases performance when there are many localizations.