Fix issue where for field of primitive list, field name and property name should be same, else crash occurs #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… of property name, resulting in crash when field name is "FieldName" and property name is "fieldname", since it wont get the property type as data
mariuskatcontentful
approved these changes
Feb 15, 2022
|
@mariuskatcontentful Please let me know how to complete the checks in the ci |
|
CI is currently broken if you run the tests locally on your machine that will suffice as well as i will check them before the merge as well |
mariuskatcontentful
approved these changes
Feb 15, 2022
mariuskatcontentful
approved these changes
Feb 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue where field name is used for fetching property type instead of property name, resulting in crash when field name is "FieldName" and property name is "fieldname", since it wont get the property type as data