Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Serialization of exception which contains closures in stacktrace cause problems #174

Closed
ghost opened this issue Sep 25, 2017 · 2 comments
Closed

Serialization of exception which contains closures in stacktrace cause problems #174

ghost opened this issue Sep 25, 2017 · 2 comments
Labels
Bug

Comments

@ghost
Copy link

ghost commented Sep 25, 2017

The serialize function of src/Log/LogEntry.php file cause problems if the exception contains closures in stack trace because it's not possible to serialize this.
@ghost ghost mentioned this issue Sep 25, 2017
Closed
@dborsatto dborsatto added the Bug label Sep 25, 2017
@dborsatto
Copy link
Contributor

I'll try to reproduce the bug, but your description makes complete sense.
The problem is, I'm not completely sure how to work around this. I'll need to investigate a bit 🤔

@ghost ghost mentioned this issue Sep 25, 2017
Merged
@ghost
Copy link
Author

ghost commented Sep 25, 2017

I've created a pr with a fix for this problem. I use the traceAsString function of the exception class to prevent this problem.

dborsatto added a commit that referenced this issue Sep 26, 2017
@dborsatto
Merge pull request #175 from bestit-tkellner/bugfix/#174-closure-seri…
546afd0 
…alization

#174 Modify exception to prevent problems with closures in stack trace.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dborsatto