Merge pull request #51 from contentful/add/429-error-handling

Add RateLimitExceeded(429) error response

CHANGELOG.md

@@ -2,6 +2,7 @@
 ## Unreleased
 ### Fixed
 * Better handling of 503 responses from the API [#48](https://github.com/contentful/contentful-management.rb/pull/48)
+* Better handling of 429 responses from the API [#51](https://github.com/contentful/contentful-management.rb/pull/51)
 
 ### Added
 * `focus` and `fit` to image handling parameters [#44](https://github.com/contentful/contentful.rb/pull/44)

lib/contentful/error.rb

@@ -21,6 +21,8 @@ def self.[](error_status_code)
         AccessDenied
       when 401
         Unauthorized
+      when 429
+        RateLimitExceeded
       when 500
         ServerError
       when 503
@@ -43,6 +45,9 @@ class AccessDenied < Error; end
   # 401
   class Unauthorized < Error; end
 
+  # 429
+  class RateLimitExceeded < Error; end
+
   # 500
   class ServerError < Error; end
 

spec/error_requests_spec.rb

@@ -21,19 +21,26 @@
     client = Contentful::Client.new(space: 'wrong', access_token: 'credentials')
 
     expect_vcr('unauthorized'){
-      client.entry 'nyancat'
+      client.entry('nyancat')
     }.to raise_error(Contentful::Unauthorized)
   end
 
   it 'will return 500 (ServerError) if ...' do
     skip
   end
 
+  it 'will return a 429 if the ratelimit is hit' do
+    client = Contentful::Client.new(space: 'wrong', access_token: 'credentials')
+    expect_vcr('ratelimit') {
+      client.entry('nyancat')
+    }.to raise_error(Contentful::RateLimitExceeded)
+  end
+
   it 'will return 503 (ServiceUnavailable) if connection time out' do
     client = Contentful::Client.new(space: 'wrong', access_token: 'credentials')
 
     expect_vcr('unavailable'){
-      client.entry 'nyancat'
+      client.entry('nyancat')
     }.to raise_error(Contentful::ServiceUnavailable)
   end
 end