Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update HTTP version #189

Merged
merged 2 commits into from
Oct 31, 2018

Conversation

scott-silver
Copy link
Contributor

The HTTP gem has a stable version 3.3.0.

Is there any reason not to bump the version in the gemspec file?

@scott-silver
Copy link
Contributor Author

looks like this requires updating Webmock as well (per this thread)

@scott-silver
Copy link
Contributor Author

@dlitvakb what do you think?

@dlitvakb
Copy link
Contributor

Hey @scott-silver,

Thanks for the contribution,

Looks good

Merging, will make a release probably later in the week.

Cheers

@dlitvakb dlitvakb merged commit 70d257d into contentful:master Oct 31, 2018
@dlitvakb
Copy link
Contributor

For some context on the version fix, until very recently we were supporting older Ruby versions, like 1.9 and 2.1 which are not compatible with the newer versions of the updated libraries.

But about 6 months ago, we fully dropped support for 1.x and about a month ago, we dropped support for older officially unsupported 2.x versions. We're still keeping 2.2 which had EOL last June for a little while, but it will be dropped some time in the near future, when we are certain that we don't have any significant usage from older ruby versions.

Cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants