NoMethodError when nodes are coerced more then once in a request

[mrGrazy]

We've bumped into a bug with rich text coercion in instances where a request includes multiple links to the same entity, for example:

We have a page with a reference to a textBlock which has a rich text field linking back to the same instance of page.

This throws an error:

NoMethodError (undefined method `[]' for <Contentful::Page[page] id='...'>:Contentful::Page):
contentful (2.11.0) lib/contentful/entry.rb:96:in `method_missing'
contentful (2.11.0) lib/contentful/coercions.rb:153:in `coerce_link'
contentful (2.11.0) lib/contentful/coercions.rb:128:in `block in coerce_block'
contentful (2.11.0) lib/contentful/coercions.rb:126:in `each'
contentful (2.11.0) lib/contentful/coercions.rb:126:in `each_with_index'
contentful (2.11.0) lib/contentful/coercions.rb:126:in `coerce_block'
contentful (2.11.0) lib/contentful/coercions.rb:136:in `block in coerce_block'
contentful (2.11.0) lib/contentful/coercions.rb:126:in `each'
contentful (2.11.0) lib/contentful/coercions.rb:126:in `each_with_index'
contentful (2.11.0) lib/contentful/coercions.rb:126:in `coerce_block'
contentful (2.11.0) lib/contentful/coercions.rb:106:in `coerce'
...

This is because when the link in the rich text is coerced, the ['target'] has already been converted to a Page model and so the guard clause fails.

I believe this pull request fixes the issue.

I would like to add a test for this case with this PR, but I don't know how as an external contributor I can add new VCR cassettes without access to the contentful space that is used for testing. Happy to add if you can tell me how 😄

[dlitvakb]

Thanks @mrGrazy,

I'll create the test case myself and push it.

Cheers

[mrGrazy]

Thanks @dlitvakb
Let me know if you need more details to reproduce it.

[dlitvakb]

Hey @mrGrazy,

Sorry for the delay, was looking for a few spare moments to get this fix in.

Will add this test case now.

Cheers

[dlitvakb]

This has now been merged and released as version 2.11.1.

Cheers

[mrGrazy]

Thanks @dlitvakb 👍