Fix marshal load of array for drafted/deleted child entries #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current behaviour for deleted/drafted entries it's different for retrieved and unserialized arrays. Let's suppose I have a model with some reference array field. And let's suppose I have a published entry with some unpublished entries on that referenced on that field. This is the current behaviour for requested arrays: ```ruby entries = client.entries(some_query) entries.first.raw['fields']['children'] entries.first.children ``` That is the right and expected behaviour, ignoring drafted entries. However, if we do the same after serializing and unserializing the array: ```ruby Marshal.load(Marshal.dump(entries)).first.children ``` This fix should solve that issue by sending the errors to the ResourceBuilder
…on array is working
|
Will merge tomorrow! Gracias! PS: @HQ063 can you revoke that access token? Given that you're also providing a Preview token, it's not advisable to make Preview tokens public. Once you revoke it, it should no longer be valid again, but the recording file for the specs will still keep working. |
|
I took the tokens and entries from another existing spec, they're not from a space I own. https://github.com/contentful/contentful.rb/blob/master/spec/entry_spec.rb#L196 |
|
Hey @HQ063, Just merged it through a different PR, Thanks for fixing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current behaviour for deleted/drafted entries it's different for retrieved and unserialized arrays.
Let's suppose I have a model with some reference array field. And let's suppose I have a published entry with some unpublished entries on that referenced on that field.
This is the current behaviour for requested arrays:
That is the right and expected behaviour, ignoring drafted entries. However, if we do the same after serializing and unserializing the array:
This fix should solve that issue by sending the errors to the ResourceBuilder