Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add aync behaviour for pure swift #44

Closed
wants to merge 1 commit into from

Conversation

mariobodemann
Copy link
Contributor

No description provided.

Copy link
Contributor

@loudmouth loudmouth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no import Dispatch

let group = DispatchGroup()
group.enter()

client.fetchEntry(identifier:"nyancat") { (result) in
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets just do this to make it more verbose ;-)

client.fetchEntry("nyancat") { (result: Result<Entry>) in


DispatchQueue.global().sync {
let group = DispatchGroup()
group.enter()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets remove this dispatch stuffs, sync stuff just isn't as relevant in the iOS world

@coveralls
Copy link

Coverage Status

Coverage remained the same at 83.691% when pulling 589e523 on fix/pure-swift-async into be98aa7 on master.

@loudmouth
Copy link
Contributor

closing for now.

@loudmouth loudmouth closed this Jun 1, 2017
@loudmouth loudmouth deleted the fix/pure-swift-async branch June 21, 2017 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants