Generate Image URL with ImageOptions #66
Conversation
loudmouth
force-pushed
the
feature/images-api
branch
from
934bf73
to
f49c5d4
Compare
loudmouth
force-pushed
the
feature/images-api
branch
from
f49c5d4
to
7443ba2
Compare
loudmouth
force-pushed
the
feature/images-api
branch
2 times, most recently
from
d33b10c
to
cca76e7
Compare
Sources/Asset.swift
Outdated
|
|
||
| public struct FileMetadata: ImmutableMappable { | ||
|
|
||
| let fileName: String |
There was a problem hiding this comment.
needs documentation.
loudmouth
force-pushed
the
feature/images-api
branch
from
cca76e7
to
b7b6b1d
Compare
Implement tests. Throw errors for invalid url construction for Images API
loudmouth
force-pushed
the
feature/images-api
branch
from
b7b6b1d
to
bedb1cd
Compare
Sources/Asset.swift
Outdated
| @@ -12,6 +12,40 @@ import ObjectMapper | |||
| /// An asset represents a media file in Contentful | |||
| public class Asset: Resource, LocalizedResource { | |||
|
|
|||
| /// URL of the media file associated with this asset. Optional for compatibility with `select` operator queries. | |||
| public var urlString: String? | |||
There was a problem hiding this comment.
Hey, do you have any plans on also supporting the upload url field? (i.e. the one used while an asset is processing?)
There was a problem hiding this comment.
this is CDA only so far. But, i suppose in the future...yes? I'm only implementing what is listed here
Sources/Asset.swift
Outdated
| return URL | ||
| } | ||
| public func url() throws -> URL { | ||
| guard let urlString = self.urlString else { throw SDKError.invalidURL(string: "") } |
There was a problem hiding this comment.
That can have a nasty side effect if the asset is uploading, doesn't it?
There was a problem hiding this comment.
This is CDA only...i'm not sure i understand what you are talking about.
| */ | ||
| public func fetchData(for asset: Asset) -> Observable<Result<Data>> { | ||
| public func fetchData(for asset: Asset, with imageOptions: [ImageOption] = []) -> Observable<Result<Data>> { |
| // and unique'ify the elements in the array. | ||
| let uniqueImageOptions = Array(Set<ImageOption>(imageOptions)) | ||
| guard uniqueImageOptions.count == imageOptions.count else { | ||
| throw SDKError.invalidImageParameters("Cannot specify two instances of ImageOption of the same case." |
There was a problem hiding this comment.
So, actually you can specify two options at the same time: http://images.contentful.com/arqlnkt58eul/2ReMHJhXoAcy4AyamgsgwQ/788a7c2210c923644b4bc20deb9a1f78/lewis-carroll-1.jpg?w=100&w=2000 will return an image with a width of 100.
| case .unspecified: | ||
| return nil | ||
| case .asPercent(let quality): | ||
| if quality > 100 { |
There was a problem hiding this comment.
it's an UInt so it's enforced to be >= 0 at compile time
There was a problem hiding this comment.
ah, okay. I wasn't able to spot the type ... ;)
Sources/ImageOptions.swift
Outdated
| // If for some reason the following code fails to create a hex string, the color black will be | ||
| // returned. | ||
| internal func hexRepresentation() -> String { | ||
| let hexForBlack = "ffffff" |
There was a problem hiding this comment.
ffffff ➡ 0? or Black ➡ White?
Sources/ImageOptions.swift
Outdated
| public enum ImageOption: Equatable, Hashable { | ||
|
|
||
| /// Specify the size of the image in pixels to be returned from the API. Valid ranges for width and height are between 0 and 4000. | ||
| case sizedTo(width: Int, height: Int) |
There was a problem hiding this comment.
Can I specify a width only? Aka, I want to scale the image to 100 pixel width, and let the aspect ratio kick in to calculate the height?
Correct hex of black from 'ffffff' to 000000'
loudmouth
force-pushed
the
feature/images-api
branch
from
6c4e997
to
11a3412
Compare
Implement tests.
Throw errors for invalid url construction for Images API