This repository has been archived by the owner on May 8, 2024. It is now read-only.
Fix severe vulnuerability - malicious package flatmap-sream removed #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closed due to committing package.lock unnecessarily. Will submit separate PR just updating package.json. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I was filling out another issue (#10) outlining a version upgrade from Jade to Pug, I realized that this project's dependencies had not been updated in some time.
There is a well known vulnerability in the package flatmap-stream, which was a subdependency of nodemon up until version 1.18.7. You can review the conversation regarding updating it on GitHub here.
This pull request simply upgrades the nodemon package to the most recent version (1.18.7), which no longer uses the malicious package. All previous functionality remains intact.
Note that I'm also happy to submit an additional pr with my upgrade from #10, and any other needed packages.