Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: markdown upload asset domain url to ctfassets.net [] #946

Merged
merged 2 commits into from
Dec 3, 2021

Conversation

cezarsmpio
Copy link
Contributor

@cezarsmpio cezarsmpio commented Dec 1, 2021

We want to guarantee that new asset uploads will use ctfassets.net as a domain instead of contentful.com

@cezarsmpio cezarsmpio requested review from a team as code owners December 1, 2021 13:43
@cezarsmpio cezarsmpio requested review from suevalov and bgutsol and removed request for a team December 1, 2021 13:43
@cezarsmpio cezarsmpio changed the title fix: markdown upload asset domain url to ctfasset.net fix: markdown upload asset domain url to ctfasset.net [] Dec 1, 2021
@github-actions github-actions bot added the tests label Dec 1, 2021
selectors.getInsertMediaDropdown().click();
selectors.getInsertNewAssetButton().click();
checkValue(
'![dog](//images.ctfassets.net/b04hhmxrptgr/6oYURL50Ddai6jRCboSB7u/b1a3768d6d987f3f6110a41175f4d7d3/dog.jpg)'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We guarantee that the domain for new assets is ctfassets.net

@cezarsmpio cezarsmpio enabled auto-merge (squash) December 1, 2021 14:30
@cezarsmpio cezarsmpio changed the title fix: markdown upload asset domain url to ctfasset.net [] fix: markdown upload asset domain url to ctfassets.net [] Dec 1, 2021
@z0al z0al requested review from leonardofreitass and removed request for suevalov and bgutsol December 2, 2021 14:58
@cezarsmpio cezarsmpio merged commit 21ef606 into master Dec 3, 2021
@cezarsmpio cezarsmpio deleted the markdown-domain-rewrite branch December 3, 2021 10:15
@Stupidism
Copy link

@cezarsmpio Looks like hostname-transformer is a private npm package:

npm install @contentful/default-field-editors

npm ERR! code E404
npm ERR! 404 Not Found - GET https://registry.npmjs.org/@contentful%2fhostname-transformer - Not found
npm ERR! 404
npm ERR! 404  '@contentful/hostname-transformer@^1.4.10' is not in the npm registry.
npm ERR! 404 You should bug the author to publish it (or use the name yourself!)
npm ERR! 404 It was specified as a dependency of '@contentful/field-editor-markdown'
npm ERR! 404
npm ERR! 404 Note that you can also install from a
npm ERR! 404 tarball, folder, http url, or git url.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants