refactor: fix dependencies and improve types #1068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suevalov
requested review from
denkristoffer,
m10l,
mshaaban0 and
a team
as code owners
denkristoffer
approved these changes
Jul 15, 2021
|
@denkristoffer I'll create a talk in my team backlog to improve ESLint setup. |
|
✔️ Deploy Preview for forma-36 ready! 🔨 Explore the source changes: b804fa0 🔍 Inspect the deploy log: https://app.netlify.com/sites/forma-36/deploys/60efed0310776d0007541e1e 😎 Browse the preview: https://deploy-preview-1068--forma-36.netlify.app |
|
@suevalov Parcel has actually fixed this in a recent nightly: parcel-bundler/parcel#6564 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of PR
Fixes missing dependencies in packages and improve typings.
Learning
We need to find an ESLint plugin that catches a situation when you use dependency but it's not specified in package.json of the corresponding package.