Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notification - Address accessibility issues #449

Merged
merged 2 commits into from
Apr 3, 2020
Merged

Notification - Address accessibility issues #449

merged 2 commits into from
Apr 3, 2020

Conversation

m10l
Copy link
Contributor

@m10l m10l commented Apr 2, 2020 •
edited
Loading

Purpose of PR

This PR introduces a redesign to the NotificiationIcon component to address some accessibility concerns.

PR Checklist

  • I have read the relevant readme.md file(s)
  • All commits follow our Git commit message convention
  • Tests are added/updated/not required
  • Tests are passing
  • Storybook stories are added/updated/not required
  • Usage notes are added/updated/not required
  • Has been tested based on Contentful's browser support
  • Doesn't contain any sensitive information

@m10l m10l self-assigned this Apr 2, 2020
@m10l m10l force-pushed the feature/notification-a11y-improvements branch from 9a3026b to 0320ba5 Compare April 2, 2020 11:16
@m10l m10l mentioned this pull request Apr 2, 2020
Closed
wichniowski
wichniowski approved these changes Apr 2, 2020
View reviewed changes
Copy link
Contributor

@wichniowski wichniowski left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome improvement! https://www.youtube.com/watch?v=GlhHMjQvJrc

@domarku
Copy link
Contributor

domarku commented Apr 3, 2020

Right on!

@m10l m10l force-pushed the feature/notification-a11y-improvements branch from 3e5d16b to de5ea28 Compare April 3, 2020 08:46
@m10l m10l merged commit f0a4cae into master Apr 3, 2020
@m10l m10l deleted the feature/notification-a11y-improvements branch April 3, 2020 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wichniowski wichniowski wichniowski approved these changes

@domarku domarku domarku approved these changes

@suevalov suevalov Awaiting requested review from suevalov

Assignees

@m10l m10l

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@m10l @domarku @wichniowski