Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EB-1565: Sidebar sometimes load and sometimes doesn't #117

Conversation

Vishvam10
Copy link

Jira Story

Work has been completed on this Jira story : https://contentstack.atlassian.net/browse/EB-1565

Overview

This PR focuses on fixing the sidebar load issue on the live-preview-sdk side

Changes Made

  • Placed LiveEditorPostMessageEvents.OPEN_QUICK_FORM appropriately in handleIndividualFields.ts
  • Fixed few minor bugs in test cases in focusOverlayWrapper.test.ts and live-preview.test.ts

@Vishvam10 Vishvam10 added the bugfix Pull request that fixes a bug label Apr 24, 2024
@Vishvam10 Vishvam10 self-assigned this Apr 24, 2024
@Vishvam10 Vishvam10 requested a review from a team as a code owner April 24, 2024 07:07
Copy link

@faraazb faraazb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@Vishvam10 Vishvam10 merged commit 7493574 into VC-115/live-editor-support Apr 24, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Pull request that fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants