-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Eb 1848: Release Preview Compare utility #127
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the later version, we will use adv-post-message. If feasible, we should incorporate that in this PR as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes looks good to me.
NIT: We could have used .cs-compare-added
, .cs-compare-removed
, .cs-compare-void-removed
, .cs-compare-void-added
instead of .green
, .red
, .void-green
and .void-red
Changing the class name could avoid any conflict in style and also could help us later supporting color customization. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!!
No description provided.