Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eb 1848: Release Preview Compare utility #127

Merged
merged 6 commits into from
May 17, 2024
Merged

Eb 1848: Release Preview Compare utility #127

merged 6 commits into from
May 17, 2024

Conversation

RavenColEvol
Copy link
Contributor

No description provided.

Copy link
Contributor

@Deepak-Kharah Deepak-Kharah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the later version, we will use adv-post-message. If feasible, we should incorporate that in this PR as well.

Copy link

@hiteshshetty-dev hiteshshetty-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good to me.
NIT: We could have used .cs-compare-added, .cs-compare-removed, .cs-compare-void-removed, .cs-compare-void-added instead of .green, .red, .void-green and .void-red

src/compare.ts Outdated Show resolved Hide resolved
@hiteshshetty-dev
Copy link

Changing the class name could avoid any conflict in style and also could help us later supporting color customization.

Copy link

@hiteshshetty-dev hiteshshetty-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@RavenColEvol RavenColEvol merged commit ebd942e into EB-1849 May 17, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants