Skip to content

Commit

Permalink
fix: changed schema view pattern comparison (#35)
Browse files Browse the repository at this point in the history
Co-authored-by: kay_alave <kay.alave@gmail.com>
  • Loading branch information
eyelesbarrow and kay_alave committed Jun 19, 2023
1 parent 796b052 commit 4360d4e
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions datahub_sap_hana/ingestion.py
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,8 @@ class HanaConfig(BasicSQLAlchemyConfig):
"""Represents the attributes needed to configure the SAP HANA DB connection"""

scheme = "hana"
schema_pattern: AllowDenyPattern = Field(default=AllowDenyPattern(deny=["*SYS*"]))
schema_pattern: AllowDenyPattern = Field(
default=AllowDenyPattern(deny=["*SYS*"]))
include_view_lineage: bool = Field(
default=False, description="Include table lineage for views"
)
Expand Down Expand Up @@ -130,7 +131,7 @@ def _get_view_lineage_elements(self) -> Dict[Tuple[str, str], List[str]]:
)
continue

if not self.config.schema_pattern.allowed(lineage.dependent_view):
if not self.config.schema_pattern.allowed(lineage.dependent_schema):
self.report.report_dropped(
f"{lineage.dependent_schema}.{lineage.dependent_view}"
)
Expand Down

0 comments on commit 4360d4e

Please sign in to comment.