Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

**Feature:** Add glossary icons #1354

Merged
merged 2 commits into from Nov 4, 2020
Merged

**Feature:** Add glossary icons #1354

merged 2 commits into from Nov 4, 2020

Conversation

fabien0102
Copy link
Contributor

Summary

image

image

To be tested

Me

  • No error or warning in the console on localhost:6060

Tester 1

  • Enter category, glossary as icon filter and check the new icons

@fabien0102 fabien0102 self-assigned this Nov 4, 2020
mpotomin
mpotomin approved these changes Nov 4, 2020
View reviewed changes
Copy link
Contributor

@mpotomin mpotomin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

Screenshot 2020-11-04 at 11 18 11

@fabien0102 fabien0102 merged commit f43b283 into master Nov 4, 2020
@fabien0102 fabien0102 deleted the glossary-icons branch November 4, 2020 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpotomin mpotomin mpotomin approved these changes

Assignees

@fabien0102 fabien0102

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fabien0102 @mpotomin