Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Website performance #807

Closed
wants to merge 1 commit into from
Closed

Website performance #807

wants to merge 1 commit into from

Conversation

peterszerzo
Copy link
Contributor

Summary

Fixes the 3s reload an the jumpiness of the website by not rendering examples if sections are out of view. Comes with the tradeoff of fixing the height of the examples section, but at least the navigation is sane and the fix is quick. We can build on top of this in the future.

To be tested

Me

  • No error or warning in the console on localhost:6060

Tester 1

  • Things look good on the demo.

Tester 2

  • Things look good on the demo.

@peterszerzo peterszerzo changed the title Fix website performance and layout bugs **Fix:** website performance Oct 26, 2018
@ImogenF
Copy link
Contributor

ImogenF commented Oct 26, 2018

scroll

I don't agree that this solves a jumpiness problem. Now, when you scroll, you have to have a significant amount of the example for a given section in view before the content appears, and you can see the content disappearing from any other partially visible sections.

@peterszerzo
Copy link
Contributor Author

By jumpiness I meant the skipped frames and sluggish navigation of the website in general due to how many example sections are being rendered. The thresholds for when sections appear and disappear can be tweaked, I'll play around them a bit more.

@ImogenF
Copy link
Contributor

ImogenF commented Oct 26, 2018

Can you display the full contents of any section that is at least partially visible on the screen?

@peterszerzo
Copy link
Contributor Author

I'd love to, as soon as I figure out how react-waypoint works.

@TejasQ TejasQ changed the title **Fix:** website performance Website performance Oct 26, 2018
@TejasQ
Copy link
Contributor

TejasQ commented Oct 26, 2018

Updated the title since this doesn't affect the library.

@TejasQ
Copy link
Contributor

TejasQ commented Oct 26, 2018

I added the work in progress label because this suggest to me that it is.

Copy link
Contributor

@TejasQ TejasQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something's pretty broken with this PR.

image

I'm not sure why, but nothing is rendered in the website...

@TejasQ
Copy link
Contributor

TejasQ commented Dec 6, 2018

@peterszerzo are there any plans to continue here?

@TejasQ
Copy link
Contributor

TejasQ commented Dec 7, 2018

Temporarily closing this because of inactivity.

@TejasQ TejasQ closed this Dec 7, 2018
@TejasQ TejasQ deleted the fix/website branch April 24, 2019 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants