Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

**Fix:** Make select filter case insensitive #836

Merged
merged 1 commit into from Nov 19, 2018
Merged

**Fix:** Make select filter case insensitive #836

merged 1 commit into from Nov 19, 2018

Conversation

TejasQ
Copy link
Contributor

@TejasQ TejasQ commented Nov 19, 2018

Summary

This PR makes filtering through dropdowns case insensitive.

To be tested

Me

  • No error or warning in the console on localhost:6060

Tester 1

  • Things look good on the demo.

Tester 2

  • Things look good on the demo.

@TejasQ TejasQ self-assigned this Nov 19, 2018
@TejasQ
Copy link
Contributor Author

TejasQ commented Nov 19, 2018

Filtering in Operational Dropdown should not be case sensitive

fabien0102
fabien0102 approved these changes Nov 19, 2018
View reviewed changes
Copy link
Contributor

@fabien0102 fabien0102 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😱

@TejasQ TejasQ merged commit 86d01f6 into master Nov 19, 2018
@TejasQ TejasQ deleted the fix/select-option-filter branch November 19, 2018 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabien0102 fabien0102 fabien0102 approved these changes

@micha-f micha-f Awaiting requested review from micha-f

Assignees

@TejasQ TejasQ

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@TejasQ @fabien0102