This repository has been archived by the owner on Jun 6, 2020. It is now read-only.
Use new viz instance when component updates #32
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this change I got an error when switch between different visualisations of Grid:
But I suspect (but no proof) that this change can have some negative consequences.
The problem is that
viz
instance has internal state, which is preserved across React component renders, which causes bugsPublished to canary as
@operational/visualizations@6.1.0-349d69e