Skip to content
This repository has been archived by the owner on Nov 11, 2023. It is now read-only.

Cover components with unit tests #1

Closed
TejasQ opened this issue Jul 2, 2018 · 5 comments
Closed

Cover components with unit tests #1

TejasQ opened this issue Jul 2, 2018 · 5 comments
Labels
help wanted Extra attention is needed

Comments

@TejasQ
Copy link
Contributor

TejasQ commented Jul 2, 2018 •
edited

Why

Unit tests are good and allow us to have predictable software.

What

Currently, components like Get and Poll work reliably and beautifully, but are not covered with unit tests. It would be nice if we had them covered with test in order to prevent side effects and surprises when consuming these components.
@TejasQ TejasQ added help wanted Extra attention is needed good first issue Good for newcomers labels Jul 2, 2018
@TejasQ TejasQ self-assigned this Jul 2, 2018
@TejasQ TejasQ removed the good first issue Good for newcomers label Jul 2, 2018
@TejasQ TejasQ removed their assignment Jul 2, 2018
@Xiot
Copy link

Xiot commented Jul 7, 2018

I can take this on!

@TejasQ
Copy link
Contributor Author

TejasQ commented Jul 7, 2018

Do it! 💪

@TejasQ
Copy link
Contributor Author

TejasQ commented Jul 16, 2018

@Xiot, still interested to finish this?

@Xiot
Copy link

Xiot commented Jul 17, 2018 via email

@TejasQ
Copy link
Contributor Author

TejasQ commented Jul 17, 2018

Would you still like to do it?

@fabien0102 fabien0102 mentioned this issue Aug 5, 2018
Merged
@TejasQ TejasQ closed this as completed Aug 27, 2018
@dwebfan dwebfan mentioned this issue May 25, 2021
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Xiot @TejasQ