This repository has been archived by the owner on Nov 11, 2023. It is now read-only.
Fix useGet url composition pattern #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabien0102
force-pushed
the
fix-use-get-url-composition
branch
from
378ca8f
to
0d75fd7
Compare
mpotomin
suggested changes
Apr 16, 2019
src/useGet.tsx
Outdated
| @@ -56,6 +56,13 @@ export interface UseGetProps<TData, TQueryParams> { | |||
| | number; | |||
| } | |||
|
|
|||
| function resolvePath<TQueryParams>(base: string, path: string, queryParams: TQueryParams) { | |||
| const escapedBase = base.endsWith("/") ? base : `${base}/`; | |||
| const escapedPath = path.startsWith("/") ? path.slice(1) : path; | |||
There was a problem hiding this comment.
escaped confuses me here - makes me think about url encoding, how about appendedBase and trimmedPath?
TejasQ
previously approved these changes
Apr 16, 2019
TejasQ
approved these changes
Apr 16, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
By lazyness, I've choose
url.resolvecomposition pattern when I implement the first version ofuseGet, the problem is that it required to add a trailing slash to theProvider.baseto be able to use the library…To resolve this, I update a bit the pattern, to permit more convenient url composition, not sure that is yet perfect but it will be test in our internals applications to validate the usage and pattern 😉