Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ICaRL to the CL Baselines #4

Closed
vlomonaco opened this issue Apr 10, 2020 · 10 comments
Closed

Add ICaRL to the CL Baselines #4

vlomonaco opened this issue Apr 10, 2020 · 10 comments
Labels
Feature - High Priority New feature or request, high priority Training Related to the Training module

Comments

@vlomonaco
Copy link
Member

Add the ICaRL strategy to the main CL Baselines.

@vlomonaco vlomonaco added the Feature - Low Priority New feature or request, low priority label Apr 10, 2020
@vlomonaco vlomonaco assigned vlomonaco and lrzpellegrini and unassigned vlomonaco May 4, 2020
@vlomonaco vlomonaco added Feature - High Priority New feature or request, high priority and removed Feature - Low Priority New feature or request, low priority labels May 10, 2020
@akshitac8
Copy link
Collaborator

@vlomonaco Can I start with this?

@lrzpellegrini
Copy link
Collaborator

Hi Akshita, I already wrote and tested the PyTorch code iCaRL (which only needs to be ported to Avalanche).

I had to pause the porting because I'm been working on max priority issues. However, I think I can still handle this!

@akshitac8
Copy link
Collaborator

okay @lrzpellegrini

@vlomonaco vlomonaco added Feature - Low Priority New feature or request, low priority and removed Feature - High Priority New feature or request, high priority labels Jun 19, 2020
@vlomonaco vlomonaco added Feature - Medium Priority New feature or request, medium priority Training Related to the Training module and removed Feature - Low Priority New feature or request, low priority labels Oct 23, 2020
@vlomonaco vlomonaco added this to TO DO in Beta Version Dec 10, 2020
@vlomonaco vlomonaco added Feature - High Priority New feature or request, high priority and removed Feature - Medium Priority New feature or request, medium priority labels Mar 8, 2021
@vlomonaco
Copy link
Member Author

This is gonna be added soon with a PR by Andrea Rosasco.

@Mathieu4141
Copy link
Contributor

Are you still working on that @andrew-r96 ? For a school project we implemented iCaRL as a baseline, and we did it using avalanche. The code is not up to date with the latest version of avalanche, but it shouldn't be too much work to clean it.
Let me know if you're still on it :)

@andrearosasco
Copy link
Contributor

Hi @Mathieu4141 thanks for the interest :)
Yeah I'm still working on it and just opened a PR here #637 if you wanna take a look.

@Mathieu4141
Copy link
Contributor

Great! Yes I'll take a look at your PR 🙂

AntonioCarta pushed a commit that referenced this issue Jul 28, 2021
Merge data incremental fix, update fork
@qsunyuan
Copy link

Hi!

Great work.

Recently I also reproduced iCaRL, but I cannot achieve the original results.

Could u pls share ur CIFAR100 icarl results.

For example, ten tasks which each task has 10 classes.

I cannot achieve the original results, about 49%. How's ur results.

1641972671(1)

Hope to get ur replay. Best wishes.

@vlomonaco
Copy link
Member Author

Hi @qsunyuan! Results on Cifar100 are reproduced here: https://github.com/ContinualAI/reproducible-continual-learning

@qsunyuan
Copy link

THx for ur help, it helps me a lot. Best wishes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature - High Priority New feature or request, high priority Training Related to the Training module
Projects
No open projects
Development

No branches or pull requests

7 participants