rewrite for good v7.x.x #15
Conversation
|
This looks fine to me. Do we know the reason "ops" events were filtered out? Did loggly not like them for some reason or did this person just not want them? If it's the former, we can just check the event type and just eat it and not do anything about it. If it's the former, then users should use a transform stream before this to filter those out. |
|
I'm not sure that it's actually a big deal - #11. |
|
Then you can probably remove that stuff entirely. If you don't ops going into loggly, then you'd filter it out somewhere else. |
|
OK. Then I'm going to get coverage on the one missing line, and this should be good to go. |
| } | ||
| _write (event, encoding, callback) { | ||
| const data = Merge({}, event); |
There was a problem hiding this comment.
I don't THINK you need to do this anymore. Each reporter pipeline get's it's own copy so you are free to edit it as you see fit.
There is still one line of coverage needed. And I'm not sure what the
goodpolicy is now for filtering out the ops events that this module rejected in previous versions. But, I wanted to get eyes on it.Closes #14