Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unhandled exception when filtering on adjacent events #194

Closed
tbolon opened this issue Sep 4, 2014 · 9 comments
Closed

Unhandled exception when filtering on adjacent events #194

tbolon opened this issue Sep 4, 2014 · 9 comments
Labels
Milestone

Comments

@tbolon
Copy link

tbolon commented Sep 4, 2014

Starting from a view, when I try to filter events around an existing one I receive an exception.

The filter generated from the context menu is @Arrived <= 10 + Arrived("event-3ffdb1ae960308d192be030000000000")

And the server response :

{
  "Error":"An unhandled error occurred while serving the request.",
  "Exception":"Sprache.ParseException: Parsing failure: unexpected '('; expected ) (Line 1, Column 67); recently consumed: hanOrEqual\
   à Sprache.ParserExtensions.Parse[T](Parser`1 parser, String input) dans d:\\BuildAgent-02\\work\\a196437855b4d142\\src\\Sprache\\ParserOfT.cs:ligne 43
   à Seq.Storage.Filters.UserExpressionSyntax.ParseStrict(String expression, IStorageEventFilter& filter, Func`2& isRelevantEventTypeHash) dans c:\\TeamCity\\buildAgent\\work\\9b28c0a5c864e317\\src\\Seq\\Storage\\Filters\\UserExpressionSyntax.cs:ligne 72
   à Seq.Server.Features.Filtering.FilterCache.GetStrict(String expression) dans c:\\TeamCity\\buildAgent\\work\\9b28c0a5c864e317\\src\\Seq.Server\\Server\\Features\\Filtering\\FilterCache.cs:ligne 33
   à Seq.Server.Storage.EventRepository.Get(Int32 count, Nullable`1 startAfter, Nullable`1 offset, Nullable`1 startFrom, Nullable`1 fromDateUtc, Nullable`1 toDateUtc, String filter, Nullable`1 shortCircuitAfter, EventRetrievalStatistics& statistics) dans c:\\TeamCity\\buildAgent\\work\\9b28c0a5c864e317\\src\\Seq.Server\\Server\\Storage\\EventRepository.cs:ligne 28
   à Seq.Server.Web.Api.Events.EventsModule.QueryEvents(String combinedFilter) dans c:\\TeamCity\\buildAgent\\work\\9b28c0a5c864e317\\src\\Seq.Server\\Server\\Web\\Api\\Events\\EventsModule.cs:ligne 116
   à Seq.Server.Web.Api.Events.EventsModule.MatchQuery(Query query) dans c:\\TeamCity\\buildAgent\\work\\9b28c0a5c864e317\\src\\Seq.Server\\Server\\Web\\Api\\Events\\EventsModule.cs:ligne 97
   à Seq.Server.Web.Api.Events.EventsModule.<.ctor>b__6(Object p) dans c:\\TeamCity\\buildAgent\\work\\9b28c0a5c864e317\\src\\Seq.Server\\Server\\Web\\Api\\Events\\EventsModule.cs:ligne 67
   à CallSite.Target(Closure , CallSite , Func`2 , Object )
   à Nancy.Routing.Route.<>c__DisplayClass4.<Wrap>b__3(Object parameters, CancellationToken context)"}

I am using Seq 1.4.12

@tbolon tbolon changed the title Unhandled exception when filtering event "around" Unhandled exception when filtering on adjacent events Sep 4, 2014
@nblumhardt
Copy link
Member

Thanks Thomas, I'll investigate now.

@nblumhardt nblumhardt added the bug label Sep 4, 2014
@nblumhardt nblumhardt added this to the 1.5 milestone Sep 4, 2014
@nblumhardt
Copy link
Member

Looks like it may be locale-dependent, I can't repro it on this machine, will spin up a French VM and test there. Thanks!

@tbolon
Copy link
Author

tbolon commented Sep 5, 2014

Yes, you are right : it's the only machine using french regional settings, and it's the only one when we made this test.

@nblumhardt
Copy link
Member

Fixed in 1.5; thanks for the report.

@nblumhardt nblumhardt modified the milestones: 1.5, 1.5.5-pre Sep 6, 2014
@kristofferlindvall
Copy link

I'm running 1.5.16 and still have this problem. Swedish locale.

@nblumhardt
Copy link
Member

@jansson thanks for the note, will check this out.

@nblumhardt nblumhardt reopened this Oct 15, 2014
@nblumhardt nblumhardt modified the milestones: 1.5.17, 1.5.5-pre Oct 15, 2014
@nblumhardt nblumhardt modified the milestones: 1.5.17, 1.5.18 Oct 22, 2014
@nblumhardt nblumhardt modified the milestones: 1.5.18, 1.5.19 Nov 4, 2014
@nblumhardt nblumhardt modified the milestones: 1.5.19, 1.6 Nov 13, 2014
@nblumhardt nblumhardt removed this from the 1.6 milestone Jan 17, 2015
@tbolon tbolon removed this from the 1.6 milestone Jan 17, 2015
@devployment
Copy link

@nblumhardt - Any news on this? I have the same issue. Running v2.0.19.

@nblumhardt
Copy link
Member

Moving to 2.1 milestone to investigate, thanks.

@nblumhardt nblumhardt added this to the 2.1 milestone Jun 17, 2015
@nblumhardt
Copy link
Member

Fixed; still had one culture dependent function hiding in sprache/Sprache#36 (will PR a resolution over there when I can come up with one).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants