This repository has been archived by the owner on Nov 28, 2017. It is now read-only.
Hostname is added for service info #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -35,6 +35,7 @@ type consulServiceState struct { | |||
| Port int // Port number where its listening | |||
| SessionID string // session id assigned by consul | |||
| stopChan chan struct{} // Channel to stop ttl refresh | |||
| Hostname string // Host name where its running | |||
There was a problem hiding this comment.
Looks like this field is not being set. Can you please set it in RegisterService()?
|
LGTM other than the minor comment.. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For bgpinspect we need host name to ip translation hence all netplugins register service info with their host name included.