Refactor: volmaster and volsupervisor need to take daemon structs as self #132
Comments
Merged
erikh
added a commit
to erikh/volplugin
that referenced
this issue
Mar 25, 2016
a668129 Merge pull request contiv-experimental#143 from mapuri/misc abc8057 set a higer start timeout for docker to avoid intermittent docker restart failures 1fd37d9 start ntpd service after installing it 7b1f5cf install dkms and dependencies for vbox in test role 6f3ed7a install time and tcpdump in dev role 9ad9d15 Merge pull request contiv-experimental#140 from mapuri/collins c141ce5 Merge pull request contiv-experimental#139 from mapuri/serf 8598d4f Merge pull request contiv-experimental#136 from mapuri/misc 75e9678 use collins container version in collins systemd config a92a6ad set node-name in serf config c08372d fix setup and cleanup logic for netmaster hosts alias 488278c Merge pull request contiv-experimental#134 from saramach/phys-dom-ansible-changes 4e88f05 Merge pull request contiv-experimental#132 from mapuri/misc 9700c21 Add user specified Bridge domain and Contract mode - Add defaults ac42176 Add user specified Bridge domain and Contract mode e80f69a Merge pull request contiv-experimental#131 from contiv/other-volplugin-fixes 9283a68 Merge pull request contiv-experimental#108 from vvb/mon_osd_separation 4d51a28 remove leftover diffs from PR contiv-experimental#131 c75429a move iptable rule installation before service start c24108b bump up the version of contiv services 8c35bea use short hostname in serf's node label 7bdd7a3 pick the etcd peer interface from hostvars f362602 install a /32 for vip in ucarp script 7b7c678 serf fixes 253e428 Merge pull request contiv-experimental#126 from mapuri/iptables 3fe1986 ansible/roles/docker: support for proper lvm thin provisioning; will improve performance without drawbacks like overlayfs. 3aab0fb add setup and cleanup of iptables rules to allow service traffic ac7ca67 renaming compute role, commenting ceph, contiv_storage roles for now 64986c1 adding a variable which defines capability of a host 84add1b fixes to enable mon and osd separation based of a flag git-subtree-dir: ansible git-subtree-split: a668129
mapuri
added a commit
to mapuri/volplugin
that referenced
this issue
Mar 25, 2016
a668129 Merge pull request contiv-experimental#143 from mapuri/misc abc8057 set a higer start timeout for docker to avoid intermittent docker restart failures 1fd37d9 start ntpd service after installing it 7b1f5cf install dkms and dependencies for vbox in test role 6f3ed7a install time and tcpdump in dev role 9ad9d15 Merge pull request contiv-experimental#140 from mapuri/collins c141ce5 Merge pull request contiv-experimental#139 from mapuri/serf 8598d4f Merge pull request contiv-experimental#136 from mapuri/misc 75e9678 use collins container version in collins systemd config a92a6ad set node-name in serf config c08372d fix setup and cleanup logic for netmaster hosts alias 488278c Merge pull request contiv-experimental#134 from saramach/phys-dom-ansible-changes 4e88f05 Merge pull request contiv-experimental#132 from mapuri/misc 9700c21 Add user specified Bridge domain and Contract mode - Add defaults ac42176 Add user specified Bridge domain and Contract mode e80f69a Merge pull request contiv-experimental#131 from contiv/other-volplugin-fixes 9283a68 Merge pull request contiv-experimental#108 from vvb/mon_osd_separation 4d51a28 remove leftover diffs from PR contiv-experimental#131 c75429a move iptable rule installation before service start c24108b bump up the version of contiv services 8c35bea use short hostname in serf's node label 7bdd7a3 pick the etcd peer interface from hostvars f362602 install a /32 for vip in ucarp script 7b7c678 serf fixes 253e428 Merge pull request contiv-experimental#126 from mapuri/iptables 3fe1986 ansible/roles/docker: support for proper lvm thin provisioning; will improve performance without drawbacks like overlayfs. 3aab0fb add setup and cleanup of iptables rules to allow service traffic ac7ca67 renaming compute role, commenting ceph, contiv_storage roles for now 64986c1 adding a variable which defines capability of a host 84add1b fixes to enable mon and osd separation based of a flag git-subtree-dir: ansible git-subtree-split: a668129
mapuri
added a commit
to mapuri/volplugin
that referenced
this issue
Mar 25, 2016
a668129 Merge pull request contiv-experimental#143 from mapuri/misc abc8057 set a higer start timeout for docker to avoid intermittent docker restart failures 1fd37d9 start ntpd service after installing it 7b1f5cf install dkms and dependencies for vbox in test role 6f3ed7a install time and tcpdump in dev role 9ad9d15 Merge pull request contiv-experimental#140 from mapuri/collins c141ce5 Merge pull request contiv-experimental#139 from mapuri/serf 8598d4f Merge pull request contiv-experimental#136 from mapuri/misc 75e9678 use collins container version in collins systemd config a92a6ad set node-name in serf config c08372d fix setup and cleanup logic for netmaster hosts alias 488278c Merge pull request contiv-experimental#134 from saramach/phys-dom-ansible-changes 4e88f05 Merge pull request contiv-experimental#132 from mapuri/misc 9700c21 Add user specified Bridge domain and Contract mode - Add defaults ac42176 Add user specified Bridge domain and Contract mode e80f69a Merge pull request contiv-experimental#131 from contiv/other-volplugin-fixes 9283a68 Merge pull request contiv-experimental#108 from vvb/mon_osd_separation 4d51a28 remove leftover diffs from PR contiv-experimental#131 c75429a move iptable rule installation before service start c24108b bump up the version of contiv services 8c35bea use short hostname in serf's node label 7bdd7a3 pick the etcd peer interface from hostvars f362602 install a /32 for vip in ucarp script 7b7c678 serf fixes 253e428 Merge pull request contiv-experimental#126 from mapuri/iptables 3fe1986 ansible/roles/docker: support for proper lvm thin provisioning; will improve performance without drawbacks like overlayfs. 3aab0fb add setup and cleanup of iptables rules to allow service traffic ac7ca67 renaming compute role, commenting ceph, contiv_storage roles for now 64986c1 adding a variable which defines capability of a host 84add1b fixes to enable mon and osd separation based of a flag git-subtree-dir: ansible git-subtree-split: a668129
erikh
pushed a commit
to erikh/volplugin
that referenced
this issue
Apr 11, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Right now we pass these around the
daemonobject quite a bit, and in volsupervisor's case, a lot of arguments that travel down the stack. We should organize these into structs the methods live on, so that they can re-use the same data without having ugly call sites.The text was updated successfully, but these errors were encountered: