Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dpi_scale problem #1137

Closed
Yaraslaut opened this issue Jul 16, 2023 · 4 comments · Fixed by #1138
Closed

dpi_scale problem #1137

Yaraslaut opened this issue Jul 16, 2023 · 4 comments · Fixed by #1138
Assignees
Labels
bug Something isn't working

Comments

@Yaraslaut
Copy link
Member

Yaraslaut commented Jul 16, 2023

Contour Terminal version

Contour Terminal Emulator 0.3.13-master-e60326e5

Installer source

Github: source code cloned

Operating System

Arch

Architecture

x86-64

Other Software

No response

Steps to reproduce

set dpi_scale to 2 in config file

Expected Behavior

No response

Actual Behavior

image

Additional notes

For comparison dpi_scale equal to 1
image

@Yaraslaut Yaraslaut added the bug Something isn't working label Jul 16, 2023
@christianparpart
Copy link
Member

I propose to remove that. Users should use don't size to configure don't size. This is a legacy workaround when dpi scale on Mac was really hard to understand for me wrt Qt and retina displays

I would suggest to get rid of this logic all together instead. What do you think?

If there are future DPI issues, we should actually fix those.

@Yaraslaut
Copy link
Member Author

I propose to remove that. Users should use don't size to configure don't size. This is a legacy workaround when dpi scale on Mac was really hard to understand for me wrt Qt and retina displays

I would suggest to get rid of this logic all together instead. What do you think?

If there are future DPI issues, we should actually fix those.

sure, we can get rid of this configuration entry. I was just trying to look how it will affect this issue #1022

@Yaraslaut Yaraslaut self-assigned this Jul 16, 2023
@christianparpart
Copy link
Member

She used dpi_scale: 1.0. I don't think so. 🤔

@Yaraslaut
Copy link
Member Author

She used dpi_scale: 1.0. I don't think so. 🤔

I was thinking that dpi_scale can affect this bug and decided to check how it will look if I have double dpi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants