Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DPI adjustment at least sometimes broken #1299

Closed
christianparpart opened this issue Oct 21, 2023 · 3 comments · Fixed by #1365
Closed

DPI adjustment at least sometimes broken #1299

christianparpart opened this issue Oct 21, 2023 · 3 comments · Fixed by #1365
Labels
bug Something isn't working frontend Contour Terminal Emulator (GUI frontend)

Comments

@christianparpart
Copy link
Member

At least I noticed that on MacOS, where I am clearly having an HiDPI screen (192x192 DPI) and I frequently attach/detach/re-attach a different screen with a different DPI value.

What should happen is, that the font size remains the same, and thus, the cell dimensions are not touched at all.

What does happen is, that the front size is either crazy big or crazy small.

This also leads to bad calculation of mouse position to grid cell mapping.

I am experiencing this issue on MacOS/X the most, but it's most likely an issue on any platform, which can adapt to DPI changes live (e.g. KDE Plasma / Windows)

@christianparpart christianparpart added bug Something isn't working frontend Contour Terminal Emulator (GUI frontend) platform: macOS topics that directly address macOS platform labels Oct 21, 2023
@whisperity
Copy link
Member

Windows 10 does the same when switching between screen configurations. It's either related to DPI or automatic scaling.

@whisperity whisperity added the platform: windows topics that directly address Windows platform label Oct 24, 2023
@christianparpart christianparpart removed platform: macOS topics that directly address macOS platform platform: windows topics that directly address Windows platform labels Dec 18, 2023
@christianparpart
Copy link
Member Author

Hey @sfc9982, sorry for the late reply, I somehow must have skipped it. We sadly must not ignore hidpi scaling settings, as otherwise, standard GUI elements (like scrollbar or popup windows) would not look nice on a high dpi screen. I finally found the root cause of the issue and have it fixed in #1365. This was the last major blocker for the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working frontend Contour Terminal Emulator (GUI frontend)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants