Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Keyboard protocol extension CSI u #1261

Merged
merged 6 commits into from
Oct 14, 2023

Conversation

christianparpart
Copy link
Member

@christianparpart christianparpart commented Oct 12, 2023

Initial support for extended CSIu.

Well, it works for shortcuts as much as neovim is concerned. I have some open minor questions and the problem that Qt does not expose ALL information the way I need it, but it's already an improvement and works backwards compatible. :)

@christianparpart christianparpart added the VT: Backend Virtual Terminal Backend (libterminal API) label Oct 12, 2023
@christianparpart christianparpart changed the base branch from master to improvement/keyboard-input October 12, 2023 19:54
@github-actions github-actions bot added the test Unit tests label Oct 12, 2023
@github-actions github-actions bot added the frontend Contour Terminal Emulator (GUI frontend) label Oct 12, 2023
@github-actions github-actions bot removed the frontend Contour Terminal Emulator (GUI frontend) label Oct 12, 2023
Base automatically changed from improvement/keyboard-input to master October 12, 2023 21:35
@christianparpart christianparpart changed the title WIP: Add Keyboard protocol extension CSI u Add Keyboard protocol extension CSI u Oct 13, 2023
@christianparpart christianparpart marked this pull request as ready for review October 13, 2023 22:20
@github-actions github-actions bot added documentation Improvements or additions to documentation frontend Contour Terminal Emulator (GUI frontend) labels Oct 13, 2023
…eturning null

Signed-off-by: Christian Parpart <christian@parpart.family>
@christianparpart christianparpart force-pushed the feature/vt-keyboard-CSIu branch 2 times, most recently from 61a519d to 4541c36 Compare October 14, 2023 09:14
Signed-off-by: Christian Parpart <christian@parpart.family>
Signed-off-by: Christian Parpart <christian@parpart.family>
…eyboardInputGenerator

Signed-off-by: Christian Parpart <christian@parpart.family>
Signed-off-by: Christian Parpart <christian@parpart.family>
@christianparpart christianparpart force-pushed the feature/vt-keyboard-CSIu branch 5 times, most recently from f237c8e to b83fb48 Compare October 14, 2023 16:06
… report key modifiers

Signed-off-by: Christian Parpart <christian@parpart.family>
@christianparpart christianparpart merged commit d12d057 into master Oct 14, 2023
63 checks passed
@christianparpart christianparpart deleted the feature/vt-keyboard-CSIu branch October 14, 2023 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation frontend Contour Terminal Emulator (GUI frontend) test Unit tests VT: Backend Virtual Terminal Backend (libterminal API)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant