Fix crush when status line is enabled #1497
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
VT: Backend
Comment on lines
+1261
to
+1266
| // implementation of targetScreen.writeText(chars, cellCount) | ||
| // is buggy and does not work correctly | ||
| // so we do not use optimization for | ||
| // ParserEvents::print(chars,cellCount) | ||
| // but write char by char | ||
| // TODO fix targetScreen.writeText(chars, cellCount) |
There was a problem hiding this comment.
I need to think a little bit about that. 🤔
Yaraslaut
force-pushed
the
fix/status_line_bug
branch
from
6d8408b
to
29551f7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixed a crush that i notice often when using status line