Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve VT text processing efficiency #692

Merged
merged 2 commits into from
Oct 21, 2022
Merged

improve VT text processing efficiency #692

merged 2 commits into from
Oct 21, 2022

Conversation

christianparpart
Copy link
Member

@christianparpart christianparpart commented May 15, 2022 •
edited

Goals:

  • less resource usage on RenderBuffer array of RenderCell's, also in order to reduce locking time on TE backend.
  • extend trivial line optimization from US ASCII to non US-ASCII text.
  • ensure processing multibyte UTF-8 across multiple scan-API calls retains UTF-8 parsing state (also have a unit test for that) <-- this sometimes breaks notcurses external tests (e.g. grid test)
  • does it make sense to wait for Optimize performance for grapheme cluster break lookup (and other tables) libunicode#43?

@christianparpart christianparpart changed the title improve VT text processing effociency improve VT text processing efficiency May 15, 2022
@github-actions github-actions bot added test Unit tests VT: Backend Virtual Terminal Backend (libterminal API) VT: rasterizer Rendering of the terminal into a pixmap using `terminal_renderer` library labels May 15, 2022
@christianparpart christianparpart force-pushed the improvement/vt-text-processing branch 11 times, most recently from 51b1579 to 9492c59 Compare May 25, 2022 18:27
@github-actions github-actions bot added the documentation Improvements or additions to documentation label May 25, 2022
@christianparpart christianparpart force-pushed the improvement/vt-text-processing branch 4 times, most recently from 92791df to cc4a76a Compare May 26, 2022 10:16
@github-actions github-actions bot removed the documentation Improvements or additions to documentation label May 26, 2022
@christianparpart christianparpart force-pushed the improvement/vt-text-processing branch 4 times, most recently from 5e86f9f to 6db65a1 Compare May 28, 2022 15:04
@christianparpart christianparpart changed the base branch from master to improvement/vt-text-processing-2 May 28, 2022 15:22
@christianparpart christianparpart mentioned this pull request May 28, 2022
Merged
@christianparpart christianparpart force-pushed the improvement/vt-text-processing-2 branch 2 times, most recently from 4605509 to fcf671f Compare May 29, 2022 18:42
@christianparpart christianparpart force-pushed the improvement/vt-text-processing branch 3 times, most recently from cadfe93 to 8f73c0e Compare October 8, 2022 15:34
@christianparpart christianparpart mentioned this pull request Oct 8, 2022
Closed
5 tasks
@christianparpart christianparpart force-pushed the improvement/vt-text-processing branch 3 times, most recently from 861ebb0 to 893d4a4 Compare October 9, 2022 09:18
@christianparpart christianparpart marked this pull request as ready for review October 9, 2022 09:22
@christianparpart christianparpart force-pushed the improvement/vt-text-processing branch 11 times, most recently from c99a7be to e77c34a Compare October 16, 2022 21:08
@github-actions github-actions bot added the CMake label Oct 20, 2022
@christianparpart christianparpart force-pushed the improvement/vt-text-processing branch 3 times, most recently from ae9f202 to abaf571 Compare October 21, 2022 10:53
@christianparpart christianparpart merged commit 92efc84 into master Oct 21, 2022
@christianparpart christianparpart deleted the improvement/vt-text-processing branch October 21, 2022 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@data-man data-man Awaiting requested review from data-man

Assignees
No one assigned
Labels
CMake test Unit tests VT: Backend Virtual Terminal Backend (libterminal API)
Projects
Live Coding
In progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@christianparpart