Work around flatpak PTY related bugs #794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
christianparpart
force-pushed
the
fix/flatpak-pty
branch
from
c1537a5
to
78ccc5b
Compare
…so forward fd 3 (fastpipe).
christianparpart
force-pushed
the
fix/flatpak-pty
branch
from
78ccc5b
to
c9da7d3
Compare
sebastian-de
added a commit
to flathub/dev.lapce.lapce
that referenced
this pull request
Sep 18, 2022
Workaround for the following flatpak bug: flatpak/flatpak#3285 Idea taken from here: contour-terminal/contour#794
sebastian-de
added a commit
to flathub/dev.lapce.lapce
that referenced
this pull request
Sep 19, 2022
Temporary workaround for the following flatpak-spawn bug: flatpak/flatpak-xdg-utils#57 Idea taken from here: contour-terminal/contour#794
sebastian-de
added a commit
to flathub/dev.lapce.lapce
that referenced
this pull request
Sep 19, 2022
Temporary workaround for the following flatpak-spawn bug: flatpak/flatpak-xdg-utils#57 Idea taken from here: contour-terminal/contour#794
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparrently one shall not enable controlling terminal for the child process, which happens to be flatpak-spawn when running within flatpak sandboxed environment. This is just a workaround for something that is hopefully(!) fixed soon-ish.
Apart from that, flatpak-spawn is now also properly forwarding file descriptor
3(stdout-fastpipe).References