Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds CI check for clang-tidy. #963

Closed
wants to merge 1 commit into from

Conversation

christianparpart
Copy link
Member

add CI check for clang-tidy.

@github-actions github-actions bot added the CI GitHub Actions & CI label Dec 29, 2022
@christianparpart christianparpart force-pushed the improvement/ci-clang-tidy branch 2 times, most recently from 32b871a to 7137cee Compare December 29, 2022 23:21
Copy link
Member

@whisperity whisperity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is already performed by the CodeChecker job. It calls Tidy. And newer versions will also be able to call CppCheck!

@whisperity
Copy link
Member

Also we can set the CI job to run Clang-Tidy in a way that it respects the .clang_tidy files. I don't remember the flag for this at the tip of my tongue but can look it up!

@christianparpart
Copy link
Member Author

This is already performed by the CodeChecker job. It calls Tidy. And newer versions will also be able to call CppCheck!

yeah, I'm mostly interested in enforcing a proper coding style. I'm not sure why clang-format is not doing that for the identifier naming conventions. IMHO that would be fitting there, too, but yeah...

@christianparpart
Copy link
Member Author

Also we can set the CI job to run Clang-Tidy in a way that it respects the .clang_tidy files. I don't remember the flag for this at the tip of my tongue but can look it up!

this would be generally a nice idea nevertheless. but with this PR, i kinda failed. I didn't find the right action to do what I want. I didn't think it would be THAT hard.
The actions I found (so far), utilizing clang-tidy, have been all way too hard-coded and very inflexible. And the current one used in this PR actually fails because it's running cmake within a docker container, and hence is missing all the dependencies for a proper run (lol).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI GitHub Actions & CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants