Test filled compare slow #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianthomas23
force-pushed
the
test_filled_compare_slow
branch
from
af9a698
to
b8a0593
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
test_filled_compare_slowwhich is a 1000 times repeated slow test, to run through lots of randomcorner_mask=Truedata sets and compare the outputs (number of lines, outers and points) formpl2014andserial. This test is not run by default as takes ~30 minutes on my 6-core dev laptop (usingpytest-xdist).Also changed asserts that line/outer/hole counts are the same after each pass into exceptions, as they usually indicate a bug in the
serialcode that need to be identified without running in debug mode.