Use fixed version of chromium for Bokeh image tests #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This sets up the linux runner for the Bokeh image tests to use a specific version of chromium, the same that is used in the Bokeh CI. The
BokehRendererimage tests, particularly the--runtextones, are very sensitive to browser version.The chromium version used is
110.0.5481.100.The idea is that whenever Bokeh update the chromium version used for CI, the same should be done here. This is relatively infrequently, certainly much less often than new releases of chromium.
There is some extra debug info in a new
test_chrome_versiontest, which just prints the versions of chrome and chromedriver that are used rather than actually testing them. This may be changed in future.