Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new
LineType
ChunkCombinedNan
to theserial
andthreaded
algorithms which returns a single numpy array per chunk containing the x, y coordinates of all the points in that chunk with lines separated by NaN. This is the internal format used in both Bokeh and HoloViews so it will simplify and improve the performance of those libraries for contour lines. Closes #289.Example:
produces
The returned tuple only ever contains one list so strictly speaking the tuple is not required, but it is used here for consistency with all other
ChunkCombined
line and fill types.The value of
nan
used is taken fromnumpy
when first required rather than the standard C++ NaN value. These are nearly always the same, but this approach ensures thatnp.isnan
will give the expected results on all platforms and compliers that numpy supports.To do (in separate PRs):
ChunkCombinedNan
. This needs investigating and the effect of performance measured.